New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for babel.config.json #10501
Conversation
We should throw if both are used in the same folder |
Good idea @nicolo-ribaudo! Refactored to match how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code point of view, this PR looks good 👍
Let's see what others (especially @loganfsmyth who implemented config resolution in Babel 7) think about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complaints from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@devongovett Could you add this new config file to https://github.com/babel/website/blob/master/docs/config-files.md? |
6ca8275
to
a78d386
Compare
(Rebased) |
Implements support for
babel.config.json
in addition to the existingbabel.config.js
. This allows root configuration to be static JSON, which has many benefits including better cacheability, easier linting, better autocomplete, and better upgrade tools. See #10495 for more details.